[go] cmd/compile: test that time.Duration.String is inlineable

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

Feb 27, 2026, 11:26:23 PM (18 hours ago) Feb 27

to Daniel Martí, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, David Chase, Keith Randall, Keith Randall, Go LUCI, Matthew Dempsky, Martin Möhrmann, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

cmd/compile: test that time.Duration.String is inlineable

This matters for encodings supporting time.Duration,
which cannot add an AppendText method due to the encoding package godoc:

    Adding encoding/decoding methods to existing types may constitute
    a breaking change, [...] The policy for packages maintained by
    the Go project is to only allow the addition of marshaling functions
    if no existing, reasonable marshaling exists.

And indeed, time.Duration does have an existing marshaling today:
as an integer, which encoding/json still uses to this day.

Thankfully, with the String method being inlineable, we can rely on
the following not allocating in the heap:

    var td time.Duration = ...
    b = append(b, td.String()...)

Lock this in so that we can rely on this pattern going forward.

For #77851.