[build] cmd/relui: remove rand.Seed call

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

4:07 PM (2 hours ago) 4:07 PM

to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Roland Shoemaker, Dmitri Shuralyov, golang-co...@googlegroups.com

Gopher Robot submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: devapp/devapp.go
Insertions: 0, Deletions: 3.

@@ -10,10 +10,8 @@
 	"context"
 	"flag"
 	"log"
-	"math/rand"
 	"net/http"
 	"os"
-	"time"
 
 	"golang.org/x/build/internal/https"
 )
@@ -34,7 +32,6 @@
 func main() {
 	https.RegisterFlags(flag.CommandLine)
 	flag.Parse()
-	rand.Seed(time.Now().UnixNano())
 
 	s := newServer(http.NewServeMux(), *staticDir, *templateDir, *reload)
 	ctx := context.Background()
```
```
The name of the file: internal/cloud/fake_aws.go
Insertions: 0, Deletions: 2.

@@ -16,8 +16,6 @@
 	"github.com/aws/aws-sdk-go/service/ec2"
 )
 
-func init() { mrand.Seed(time.Now().UnixNano()) }
-
 // FakeAWSClient provides a fake AWS Client used to test the AWS client
 // functionality.
 type FakeAWSClient struct {
```

Change information

Commit message:

cmd/relui, devapp: remove rand.Seed call

It's not needed as of Go 1.20, the generator
is seeded randomly at program startup anyway.

Change-Id: Ic1f5cd84df333a73c8bd39be70f88df03c690e81

Reviewed-on: https://go-review.googlesource.com/c/build/+/599736

Reviewed-by: Dmitri Shuralyov <dmit...@google.com>

Reviewed-by: Ian Lance Taylor <ia...@google.com>

Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

M cmd/relui/main.go
M devapp/devapp.go
M internal/cloud/fake_aws.go

Change size: XS

Delta: 3 files changed, 0 insertions(+), 8 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Ian Lance Taylor, +1 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages