[tools] go/analysis/passes/stdversion: suppress synctest warning

1 view

Skip to first unread message

Madeline Kalil (Gerrit)

unread,

Dec 23, 2025, 11:16:47 AM (2 days ago) Dec 23

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Alan Donovan, golang-co...@googlegroups.com

Madeline Kalil submitted the change

Change information

Commit message:

go/analysis/passes/stdversion: suppress synctest warning

Some files that use synctest have complex build tags
that ensure that the synctest package is available
but do not necessarily imply that the go version is
go 1.25. We suppress the error to avoid false
positives in this case by relaxing the check
to go1.24.

Fixes golang/go#75367

Change-Id: Ifd586eba2dd63e7945d8a85bc36d704a3672e520

Reviewed-on: https://go-review.googlesource.com/c/tools/+/731461

Reviewed-by: Alan Donovan <adon...@google.com>

Auto-Submit: Madeline Kalil <mka...@google.com>

TryBot-Bypass: Madeline Kalil <mka...@google.com>

Files:

M go/analysis/passes/stdversion/stdversion.go
M gopls/internal/test/marker/marker_test.go
A gopls/internal/test/marker/testdata/diagnostics/stdversion_synctest.txt
M internal/mcp/conformance_test.go

Change size: S

Delta: 4 files changed, 40 insertions(+), 4 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Alan Donovan
TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI, TryBot-Bypass+1 by Madeline Kalil

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages