[tools] all: assume GODEBUG=gotypesalias=1 and simplify

0 views

Skip to first unread message

Alan Donovan (Gerrit)

unread,

Jan 16, 2026, 10:13:39 AM (2 days ago) Jan 16

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Robert Griesemer, Go LUCI, Robert Griesemer, golang-co...@googlegroups.com

Alan Donovan submitted the change

Change information

Commit message:

all: assume GODEBUG=gotypesalias=1 and simplify

The shims in internal/aliases have all been melted down,
except for New (nee NewAlias).

For golang/go#76472

Change-Id: Ib1ce86fe77697c76bf61ef3eb8fa20aef6e893a0

Reviewed-on: https://go-review.googlesource.com/c/tools/+/736860

Reviewed-by: Robert Griesemer <g...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Auto-Submit: Alan Donovan <adon...@google.com>

Commit-Queue: Alan Donovan <adon...@google.com>

Files:

M go/callgraph/vta/testdata/src/callgraph_type_aliases.go
M go/callgraph/vta/vta_test.go
M go/packages/packages_test.go
M go/ssa/builder_test.go
M go/ssa/subst.go
M go/types/objectpath/objectpath.go
M go/types/objectpath/objectpath_test.go
M gopls/internal/test/marker/testdata/hover/hover.txt
M gopls/internal/test/marker/testdata/modfile/godebug.txt
M gopls/internal/test/marker/testdata/modfile/godebug_bad.txt
M gopls/internal/test/marker/testdata/workfile/godebug.txt
M gopls/internal/test/marker/testdata/workfile/godebug_bad.txt
M internal/aliases/aliases.go
D internal/aliases/aliases_go122.go
M internal/aliases/aliases_test.go
M internal/facts/facts_test.go
M internal/facts/imports.go
M internal/gcimporter/gcimporter_test.go
M internal/gcimporter/iexport.go
M internal/gcimporter/iexport_go118_test.go
M internal/gcimporter/iexport_test.go
M internal/gcimporter/iimport.go
M internal/gcimporter/shallow_test.go
M internal/gcimporter/stdlib_test.go
M internal/gcimporter/ureader_yes.go
M internal/typeparams/free.go
M internal/typeparams/free_test.go
M internal/typesinternal/types.go
M internal/typesinternal/zerovalue_test.go
M refactor/rename/rename_test.go

Change size: L

Delta: 30 files changed, 79 insertions(+), 337 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Robert Griesemer
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages