[tools] all: replace xcontext.Detach and notDone with context.WithoutCancel

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

May 11, 2026, 1:47:06 PM (10 hours ago) May 11

to nveuhp, Gerrit Bot, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Hyang-Ah Hana Kim, golang...@luci-project-accounts.iam.gserviceaccount.com, Hongxiang Jiang, Alan Donovan, Robert Findley, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

all: replace xcontext.Detach and notDone with context.WithoutCancel

xcontext.Detach and notDone type from internal/jsonrpc2_v2/conn.go
implement derived context that is not cancelled when parent is
cancelled, duplicating the code of context.WithoutCancel.

Replace them with context.WithoutCancel and remove xcontext package,
because it contains only xcontext.Detach.

Change-Id: I4cb190e5db589dbea8a52fcc4b6060bedcdc0fa5

GitHub-Last-Rev: e10dfb7b859a8e71a63bd46370deb348ebca4e57

GitHub-Pull-Request: golang/tools#647

Reviewed-on: https://go-review.googlesource.com/c/tools/+/776640

Reviewed-by: Alan Donovan <adon...@google.com>

Reviewed-by: Hyang-Ah Hana Kim <hya...@gmail.com>

Auto-Submit: Hyang-Ah Hana Kim <hya...@gmail.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Commit-Queue: Hyang-Ah Hana Kim <hya...@gmail.com>

Files:

M gopls/internal/cache/load.go
M gopls/internal/cache/session.go
M gopls/internal/cache/view.go
M gopls/internal/lsprpc/export_test.go
M gopls/internal/progress/progress.go
M gopls/internal/protocol/context.go
M gopls/internal/protocol/protocol.go
M gopls/internal/server/command.go
M gopls/internal/server/general.go
M gopls/internal/server/text_synchronization.go
M gopls/internal/server/vulncheck_prompt.go
M gopls/internal/test/integration/fake/editor.go
M gopls/internal/test/integration/runner.go
M gopls/internal/test/integration/wrappers.go
M gopls/internal/util/memoize/memoize.go
M internal/jsonrpc2_v2/conn.go
D internal/xcontext/xcontext.go

Change size: M

Delta: 17 files changed, 27 insertions(+), 77 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Alan Donovan, +2 by Hyang-Ah Hana Kim
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages