[build/luci-config] main.star: set {gc,asm}flags via GO_{GC,TEST_ASM}FLAGS in spectre runmod

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

9:02 AM (14 hours ago) 9:02 AM

to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Pratt, Dmitri Shuralyov, Go LUCI, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

main.star: set {gc,asm}flags via GO_{GC,TEST_ASM}FLAGS in spectre runmod

cmd/dist unsets any GOFLAGS value that might be set in the environment
to make the build and test environment more predictable. It is however
possible to provide gcflags to make.bash via the GO_GCFLAGS. It leaves
asmflags that also need to be set somehow, which is now done via a new
environment variable added to dist test in CL 758740 for this purpose.

Constrain the builder to start at Go 1.27 since we don't have a way to
set asmflags in 1.26 and 1.25, not without backporting something there.

No need to set skip_x_repos = true since the spectre runmod is enabled
only for postsubmit of the main Go repo anyway, and start making it
available for optional presubmit since that might be helpful to check
that, e.g., a problem is correctly reported on a revert of CL 741541.

For golang/go#77427.

Change-Id: Ia5fdf699197c73953a070cd3e67ab6911179718e

Reviewed-on: https://go-review.googlesource.com/c/build/+/758840

Reviewed-by: Michael Pratt <mpr...@google.com>

Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Dmitri Shuralyov <dmit...@google.com>

Files: