[tools] gopls/internal/server: produce DocumentChange list in golang.Rename

1 view

Skip to first unread message

Gopher Robot (Gerrit)

unread,

Oct 7, 2025, 4:12:24 PM (16 hours ago) Oct 7

to Madeline Kalil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Robert Findley, golang-co...@googlegroups.com

Gopher Robot submitted the change

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

gopls/internal/server: produce DocumentChange list in golang.Rename

Previously, golang.Rename returned isPkgRenaming and then the server
package add additional DocumentChanges before returning the final list.
This CL moves the logic for creating all edits and transforming them
to a list of DocumentChanges to the golang package.

Change-Id: Iaff2be270cc954ac1d0611cdfa901347247ce21c

Reviewed-on: https://go-review.googlesource.com/c/tools/+/708955

Auto-Submit: Madeline Kalil <mka...@google.com>

Reviewed-by: Robert Findley <rfin...@google.com>

TryBot-Bypass: Madeline Kalil <mka...@google.com>

Files:

M gopls/internal/golang/rename.go
M gopls/internal/server/rename.go

Change size: M

Delta: 2 files changed, 40 insertions(+), 41 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Robert Findley
TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI, TryBot-Bypass+1 by Madeline Kalil

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages