[tools] x/tools: go fix
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Nov 10, 2025, 2:52:46 PM (2 days ago) Nov 10
to Alan Donovan, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Robert Findley, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
x/tools: go fix
The command was run twice, the second time to clean up after
the first e.g. by removing x := x. No problems observed.
Most fixes are from typefor, stditerators, buildtag, which
do not have known issues. (Several bugs in other analyzers
have been fixed since we last vendored x/tools into go fix.)
Also, use (*types.Func).Signature throughout.
For golang/go#71859
Change-Id: Icb9ba713315c469a2e307243b2d11bcd809d134f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/718504
Reviewed-by: Robert Findley <rfin...@google.com>
Auto-Submit: Alan Donovan <adon...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M go/analysis/checker/checker.go
- M go/analysis/passes/cgocall/cgocall.go
- M go/analysis/passes/copylock/copylock.go
- M go/analysis/passes/deepequalerrors/deepequalerrors.go
- M go/analysis/passes/httpmux/httpmux.go
- M go/analysis/passes/inline/inline.go
- M go/analysis/passes/inspect/inspect.go
- M go/analysis/passes/loopclosure/loopclosure.go
- M go/analysis/passes/lostcancel/lostcancel.go
- M go/analysis/passes/printf/types.go
- M go/analysis/passes/slog/slog.go
- M go/analysis/passes/testinggoroutine/util.go
- M go/analysis/passes/unmarshal/unmarshal.go
- M go/analysis/passes/unusedresult/unusedresult.go
- M go/callgraph/rta/rta.go
- M go/callgraph/static/static.go
- M go/ssa/builder.go
- M go/ssa/instantiate_test.go
- M go/ssa/interp/reflect.go
- M go/ssa/ssautil/visit.go
- M go/ssa/subst.go
- M go/ssa/util.go
- M go/types/internal/play/play.go
- M go/types/objectpath/objectpath.go
- M go/types/typeutil/map.go
- M gopls/internal/analysis/simplifycompositelit/simplifycompositelit.go
- M gopls/internal/analysis/unusedparams/unusedparams.go
- M gopls/internal/cache/constraints_test.go
- M gopls/internal/cache/parsego/parse.go
- M gopls/internal/doc/generate/generate.go
- M gopls/internal/golang/completion/completion.go
- M gopls/internal/golang/completion/format.go
- M gopls/internal/golang/completion/fuzz.go
- M gopls/internal/golang/completion/literal.go
- M gopls/internal/golang/completion/postfix_snippets.go
- M gopls/internal/golang/completion/statements.go
- M gopls/internal/golang/completion/util.go
- M gopls/internal/golang/hover.go
- M gopls/internal/golang/implementation.go
- M gopls/internal/golang/inlay_hint.go
- M gopls/internal/golang/pkgdoc.go
- M gopls/internal/golang/rename_check.go
- M gopls/internal/golang/stubmethods/stubcalledfunc.go
- M gopls/internal/golang/stubmethods/stubmethods.go
- M gopls/internal/golang/types_format.go
- M gopls/internal/lsprpc/autostart_posix.go
- M gopls/internal/protocol/command/commandmeta/meta.go
- M gopls/internal/protocol/command/gen/gen.go
- M gopls/internal/protocol/command/generate.go
- M gopls/internal/protocol/uri_test.go
- M gopls/internal/protocol/uri_windows_test.go
- M gopls/internal/telemetry/telemetry_test.go
- M gopls/internal/test/integration/misc/generate_test.go
- M gopls/internal/test/integration/workspace/quickfix_test.go
- M gopls/internal/test/marker/marker_test.go
- M gopls/internal/util/fingerprint/fingerprint.go
- M gopls/internal/util/frob/frob.go
- M gopls/internal/util/typesutil/typesutil.go
- M gopls/internal/vulncheck/copier.go
- M internal/analysisinternal/typeindex/typeindex.go
- M internal/facts/imports.go
- M internal/gcimporter/bexport_test.go
- M internal/gcimporter/gcimporter_test.go
- M internal/gcimporter/iexport.go
- M internal/refactor/inline/callee.go
- M internal/typeparams/common_test.go
- M internal/typeparams/normalize.go
- M internal/typesinternal/element.go
- M internal/typesinternal/isnamed.go
- M internal/typesinternal/zerovalue.go
- M refactor/eg/eg.go
- M refactor/rename/check.go
- M refactor/rename/rename.go
- M refactor/rename/util.go
- M refactor/satisfy/find.go
Change size: L
Delta: 75 files changed, 200 insertions(+), 243 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Robert Findley
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages