[go] cmd/cgo: read CGO_LDFLAGS environment variable

1 view
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Jul 3, 2024, 3:02:49 PM (2 days ago) Jul 3
to Ian Lance Taylor, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Cherry Mui, Go LUCI, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
cmd/cgo: read CGO_LDFLAGS environment variable

For #66456 we changed from the CGO_LDFLAGS environment variable to
the -ldflags option. This broke Bazel, which uses CGO_LDFLAGS.
So restore reading CGO_LDFLAGS for now.

For #66456
Change-Id: Iebdd8bde1c7c18da09c6370e284c7ac7fa08fc54
Reviewed-by: Ian Lance Taylor <ia...@google.com>
Auto-Submit: Ian Lance Taylor <ia...@google.com>
Commit-Queue: Ian Lance Taylor <ia...@google.com>
Auto-Submit: Ian Lance Taylor <ia...@golang.org>
Reviewed-by: Cherry Mui <cher...@google.com>
Files:
  • M src/cmd/cgo/main.go
Change size: S
Delta: 1 file changed, 15 insertions(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Ian Lance Taylor, +2 by Cherry Mui
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Iebdd8bde1c7c18da09c6370e284c7ac7fa08fc54
Gerrit-Change-Number: 596615
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages