[telemetry] internal/upload: use UTC time in TestRun_Concurrent

0 views
Skip to first unread message

Robert Findley (Gerrit)

unread,
Jul 3, 2024, 10:31:50 AM (2 days ago) Jul 3
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Hyang-Ah Hana Kim, Go LUCI, golang-co...@googlegroups.com

Robert Findley submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
internal/upload: use UTC time in TestRun_Concurrent

When (1) UTC time is in the next day, and (2) weekends day is exactly
right, the first count in TestRun_Concurrent will fall to be aggregated
into a report whose end date is too old. As a result, we can expect
approximately a (7/24)*(1/7) = 4% flake rate.

Fix this by correcting the counter time to UTC and pinning the upload
start time, so that the first count will not be on an earlier day, and
we avoid date skew.

Fixes golang/go#67737
Change-Id: If3b99afe4cbb6d12aa3e87177fc663f4c20ebd12
Reviewed-by: Hyang-Ah Hana Kim <hya...@gmail.com>
Files:
  • M internal/upload/findwork.go
  • M internal/upload/run_test.go
Change size: S
Delta: 2 files changed, 10 insertions(+), 6 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Hyang-Ah Hana Kim
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: telemetry
Gerrit-Branch: master
Gerrit-Change-Id: If3b99afe4cbb6d12aa3e87177fc663f4c20ebd12
Gerrit-Change-Number: 596316
Gerrit-PatchSet: 3
Gerrit-Owner: Robert Findley <rfin...@google.com>
Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Reviewer: Robert Findley <rfin...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages