[exp] trace: regenerate to include CL 691815

2 views
Skip to first unread message

Nick Ripley (Gerrit)

unread,
Dec 19, 2025, 3:36:49 PM (2 days ago) Dec 19
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Carlos Amedee, Michael Knyszek, Go LUCI, golang-co...@googlegroups.com

Nick Ripley submitted the change

Change information

Commit message:
trace: regenerate to include CL 691815

This CL makes the following changes to gen.bash:

- Clean up files at the start to make it easier to work on gen.bash.
The only ones we don't clean up are gen.bash itself and the
experimental version of the flight recorder.
- Copy the internal/diff package, which is a new test-only dependency.
- Replace the new test-only internal/testenv dependency with an inlined
version of the only fuction the tests actually use, testenv.Builder().
- Replace the t.ArtifactDir call in the tests with t.TempDir.
t.ArtifactDir is a Go 1.26+ API, and we don't want to require that
yet. We generally don't expect these tests to break unlesss they were
broken at the time we mirror the code, so we don't lose much with this
change.

Fixes golang/go#76751

[git-generate]
cd trace
./gen.bash 54b82e9
Change-Id: I6a6a6964c10350dcab290b45f6481a26ed26d9be
Reviewed-by: Carlos Amedee <car...@golang.org>
Reviewed-by: Michael Knyszek <mkny...@google.com>
Files:
  • M trace/base.go
  • M trace/event.go
  • M trace/event_test.go
  • M trace/gen.bash
  • A trace/internal/diff/diff.go
  • A trace/internal/diff/diff_test.go
  • A trace/internal/diff/testdata/allnew.txt
  • A trace/internal/diff/testdata/allold.txt
  • A trace/internal/diff/testdata/basic.txt
  • A trace/internal/diff/testdata/dups.txt
  • A trace/internal/diff/testdata/end.txt
  • A trace/internal/diff/testdata/eof.txt
  • A trace/internal/diff/testdata/eof1.txt
  • A trace/internal/diff/testdata/eof2.txt
  • A trace/internal/diff/testdata/long.txt
  • A trace/internal/diff/testdata/same.txt
  • A trace/internal/diff/testdata/start.txt
  • A trace/internal/diff/testdata/triv.txt
  • M trace/internal/raw/textreader.go
  • A trace/internal/testtrace/helpers.go
  • A trace/internal/testtrace/helpers_test.go
  • A trace/internal/testtrace/platforms.go
  • M trace/reader_test.go
  • M trace/resources.go
  • M trace/value.go
Change size: XL
Delta: 25 files changed, 2114 insertions(+), 106 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Carlos Amedee, +2 by Michael Knyszek
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: exp
Gerrit-Branch: master
Gerrit-Change-Id: I6a6a6964c10350dcab290b45f6481a26ed26d9be
Gerrit-Change-Number: 724442
Gerrit-PatchSet: 4
Gerrit-Owner: Nick Ripley <nick....@datadoghq.com>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Nick Ripley <nick....@datadoghq.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages