[go] Revert "crypto/internal/fips140/subtle: add assembly implementation of xorBytes for mipsx"
0 views
Skip to first unread message
Keith Randall (Gerrit)
Oct 7, 2025, 4:52:50 PM (15 hours ago) Oct 7
to Keith Randall, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Keith Randall, Cherry Mui, Michael Knyszek, Julian Zhu, Roland Shoemaker, Gopher Robot, Joel Sing, Daniel McCarney, golang-co...@googlegroups.com
Keith Randall submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/crypto/internal/fips140/subtle/xor_asm.go
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Revert "crypto/internal/fips140/subtle: add assembly implementation of xorBytes for mipsx"
This reverts commit 343e486bfdbf9ca614d3e197afd79ad7ed5fef3e.
Reason for revert: doesn't handle unaligned accesses correctly.
Update #74998
Change-Id: I1d6210eeca9336f2ce311e99944cb270565563aa
Reviewed-on: https://go-review.googlesource.com/c/go/+/709795
Reviewed-by: Cherry Mui <cher...@google.com>
Reviewed-by: Michael Knyszek <mkny...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <k...@google.com>
Files:
- M src/crypto/internal/fips140/subtle/xor_asm.go
- M src/crypto/internal/fips140/subtle/xor_generic.go
- D src/crypto/internal/fips140/subtle/xor_mipsx.s
Change size: M
Delta: 3 files changed, 2 insertions(+), 214 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Cherry Mui, +2 by Michael Knyszek, +1 by Keith Randall
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages