[tools] gopls/internal/golang/stubmethods: fix internal error (missing type)

[Alan Donovan (Gerrit)]

Alan Donovan submitted the change

Change information

Commit message:

gopls/internal/golang/stubmethods: fix internal error (missing type)

EnclosingSignature can return nil when there are duplicate
function declarations of the same name. Previously this triggered
a bug.Report (in fact two, in the past) and an internal error.
This change documents and tests it and downgrades it to an
expected error.

Fixes golang/go#70666

Change-Id: I809d55fe5af6d8a0d87560da29cc8a2471637e83

Reviewed-on: https://go-review.googlesource.com/c/tools/+/787360

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Hongxiang Jiang <hxj...@golang.org>

Files:

• M gopls/internal/golang/stubmethods/stubmethods.go
• A gopls/internal/test/marker/testdata/quickfix/stubmethods/issue70666.txt
• M gopls/internal/util/typesutil/typesutil.go

Change size: M

Delta: 3 files changed, 50 insertions(+), 13 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Hongxiang Jiang
• TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: tools

Gerrit-Branch: master

Gerrit-Change-Id: I809d55fe5af6d8a0d87560da29cc8a2471637e83

Gerrit-Change-Number: 787360

Gerrit-PatchSet: 3

Gerrit-Owner: Alan Donovan <adon...@google.com>

Gerrit-Reviewer: Alan Donovan <adon...@google.com>

Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>

Gerrit-Reviewer: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>