[go] cmd/compile: repair mask optimizations
0 views
Skip to first unread message
David Chase (Gerrit)
Jun 26, 2026, 3:46:27 PM (yesterday) Jun 26
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Junyang Shao, Cherry Mui, golang...@luci-project-accounts.iam.gserviceaccount.com, Sanjay Menakuru, Keith Randall, Gopher Robot, golang-co...@googlegroups.com
David Chase submitted the change![]( "Open in Gerrit")
Change information
Commit message:
cmd/compile: repair mask optimizations
Had sense of the instructions wrong.
XORQ means a Q of mask bits (64),
not mask bits for Qs (2/4/8).
Includes a not-comprehensive-across operations
test that IS comprehensive across width x count
combinations, to slightly validate use of "B"
mask operations (8 bits) for results of 2 and 4
element comparisons.
Fixes #80140.
Change-Id: I7537bb3327ae124d216f24e4fa054510d8c7cf3c
Reviewed-on: https://go-review.googlesource.com/c/go/+/794680
Reviewed-by: Junyang Shao <shaoj...@google.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M src/cmd/compile/internal/ssa/_gen/AMD64.rules
- M src/cmd/compile/internal/ssa/rewriteAMD64.go
- M src/simd/archsimd/internal/simd_test/simd_amd64_test.go
Change size: L
Delta: 3 files changed, 346 insertions(+), 131 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Junyang Shao
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages