[sys] cpu: roll back "use IsProcessorFeaturePresent to calculate ARM64 on windows"

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
4:12 PM (4 hours ago) 4:12 PM
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Pratt, Carlos Amedee, Dmitri Shuralyov, Go LUCI, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
cpu: roll back "use IsProcessorFeaturePresent to calculate ARM64 on windows"

Roll back CL 740880 (commit fc646e489fd944b6f77d327ab77f1a4bab81d5ad)
because it adds a golang.org/x/sys/windows import to the cpu package.
The cpu package is vendored into the main Go tree and the policy there
does not currently permit this dependency.

For golang/go#76791.
Fixes golang/go#78259.
Change-Id: I72860cdf98192f4cbd2b3398926203a752d8d0fe
Cq-Include-Trybots: luci.golang.try:x_sys-gotip-windows-arm64
Reviewed-by: Michael Pratt <mpr...@google.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>
Files:
  • M cpu/cpu_other_arm64.go
  • D cpu/cpu_windows_arm64.go
Change size: S
Delta: 2 files changed, 1 insertion(+), 43 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Michael Pratt, +1 by Dmitri Shuralyov
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sys
Gerrit-Branch: master
Gerrit-Change-Id: I72860cdf98192f4cbd2b3398926203a752d8d0fe
Gerrit-Change-Number: 757482
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages