[tools] gopls/internal/golang: InlayHint: permit "ignore error" alternatives
0 views
Skip to first unread message
Gopher Robot (Gerrit)
1:05 PM (4 hours ago) 1:05 PM
to Alan Donovan, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Alex Putman, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
gopls/internal/golang: InlayHint: permit "ignore error" alternatives
This change causes the ignoredError inlay hint to check for a
variety of common strings such as "can't fail". Any of them will
suppress the hint.
+ test, doc
Change-Id: I820848ce19f0b5332878922235025bdad2a3cbaf
Reviewed-on: https://go-review.googlesource.com/c/tools/+/801800
Auto-Submit: Alan Donovan <adon...@google.com>
Reviewed-by: Alex Putman <apu...@golang.org>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M gopls/doc/inlayHints.md
- M gopls/internal/doc/api.json
- M gopls/internal/golang/inlay_hint.go
- M gopls/internal/settings/settings.go
- M gopls/internal/test/marker/testdata/inlayhints/ignored-error.txt
Change size: M
Delta: 5 files changed, 42 insertions(+), 15 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Alex Putman
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages