[build] internal/workflow: correct type for constant, taskResult, expansionResult
1 view
Skip to first unread message
Gopher Robot (Gerrit)
Oct 7, 2025, 3:42:50 PM (16 hours ago) Oct 7
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Alan Donovan, Go LUCI, Dmitri Shuralyov, shuang cui, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
internal/workflow: correct type for constant, taskResult, expansionResult
The type was already correct for parameter and slice, but these three
had an extra slice on top of T. Thanks to Alan for noticing this during
the review of CL 709155.
Also switch to reflect.TypeFor in one more place.
Change-Id: I1fd2db001b0cbad1f13ba8ca342f98df75a2db29
Reviewed-on: https://go-review.googlesource.com/c/build/+/709516
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>
Reviewed-by: Alan Donovan <adon...@google.com>
Files:
- M internal/workflow/workflow.go
Change size: XS
Delta: 1 file changed, 4 insertions(+), 5 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Alan Donovan, +1 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages