[tools] gopls/internal/protocol: patch RenameParams to extend PositionParams
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Dec 16, 2025, 8:17:41 PM (8 hours ago) Dec 16
to Hongxiang Jiang, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Alan Donovan, Go LUCI, Madeline Kalil, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
gopls/internal/protocol: patch RenameParams to extend PositionParams
The LSP states that RenameParams extends TextDocumentPositionParams.
However, the source json definition flattens the text document and
position fields directly to Renameparams, rather than preserving
the inheritance.
This change manually patches the parsed model ensuring the generated
code correctly embeds PositionParams matching the LSP.
Change-Id: I265ceab5fc5c7ce08cfca2ceb81cc9a52f0be503
Reviewed-on: https://go-review.googlesource.com/c/tools/+/730040
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Hongxiang Jiang <hxj...@golang.org>
Reviewed-by: Alan Donovan <adon...@google.com>
Files:
- M gopls/internal/cmd/rename.go
- M gopls/internal/protocol/generate/main.go
- M gopls/internal/protocol/generate/output.go
- M gopls/internal/protocol/tsprotocol.go
- M gopls/internal/protocol/tsserver.go
- M gopls/internal/test/integration/fake/editor.go
- M gopls/internal/test/marker/marker_test.go
Change size: M
Delta: 7 files changed, 68 insertions(+), 81 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Alan Donovan
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages