[tools] gopls/internal/cmd: fix flaky mcp http test

[Gopher Robot (Gerrit)]

Gopher Robot submitted the change

Change information

Commit message:

gopls/internal/cmd: fix flaky mcp http test

In the most recent flake of the TestMCPCommandHTTP, the call
to client.Connect failed even though the preceding call to net.Dial
was successful. This could happen if the port is open,
but client.Connect is called before the MCP HTTP server is
finished setting up the request handlers.

Change-Id: I044e98c69171e897278c337cce1e384840393f71

Reviewed-on: https://go-review.googlesource.com/c/tools/+/686675

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Robert Findley <rfin...@google.com>

Commit-Queue: Alan Donovan <adon...@google.com>

Auto-Submit: Alan Donovan <adon...@google.com>

Reviewed-by: Alan Donovan <adon...@google.com>

Files:

• M gopls/internal/cmd/mcp_test.go

Change size: S

Delta: 1 file changed, 7 insertions(+), 6 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Alan Donovan, +2 by Robert Findley
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: tools

Gerrit-Branch: master

Gerrit-Change-Id: I044e98c69171e897278c337cce1e384840393f71

Gerrit-Change-Number: 686675

Gerrit-PatchSet: 3

Gerrit-Owner: Madeline Kalil <mka...@google.com>

Gerrit-Reviewer: Alan Donovan <adon...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Gopher Robot <go...@golang.org>

Gerrit-Reviewer: Madeline Kalil <mka...@google.com>

Gerrit-Reviewer: Robert Findley <rfin...@google.com>