[go] encoding/json/v2: remove issue reference in Duration formatting error

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
10:31 AM (3 hours ago) 10:31 AM
to Joseph Tsai, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Damien Neil, Michael Pratt, Go LUCI, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
encoding/json/v2: remove issue reference in Duration formatting error

The json/v2 working group decided to commit to no default representation
for time.Duration for the foreseeable future.
Thus, we can remove the issue reference in the error message.

If JavaScript (TC39) formally adopts the Temporal.Duration type,
which uses ISO 8601 as the JSON representation for a duration,
we may consider changing the default.

Switching from no default to some default in the future
is generally a compatible change.

Updates #71631
Change-Id: I6f71a0fa97dcefba56aab0c0ddf445d9d38f6e58
Reviewed-by: Michael Pratt <mpr...@google.com>
Reviewed-by: Damien Neil <dn...@google.com>
Auto-Submit: Joseph Tsai <joe...@digital-static.net>
Files:
  • M src/encoding/json/v2/arshal_time.go
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Damien Neil, +2 by Michael Pratt
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6f71a0fa97dcefba56aab0c0ddf445d9d38f6e58
Gerrit-Change-Number: 735080
Gerrit-PatchSet: 2
Gerrit-Owner: Joseph Tsai <joe...@digital-static.net>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Joseph Tsai <joe...@digital-static.net>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages