[tools] go/analysis/passes/modernize: errorsastype: support negative case

[Madeline Kalil (Gerrit)]

Madeline Kalil submitted the change

Change information

Commit message:

go/analysis/passes/modernize: errorsastype: support negated case

Support an additional pattern:

var myerr *MyErr
if errors.As(err, &myerr) { ... }

=>

if myerr, ok := errors.AsType[*MyErr](err); !ok { ... }

For golang/go#75692

Change-Id: I3d9a378a4ea101f6e7d3e7c4a6e3beba417e3212

Reviewed-on: https://go-review.googlesource.com/c/tools/+/779800

Reviewed-by: Alan Donovan <adon...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

• M go/analysis/passes/modernize/errorsastype.go
• M go/analysis/passes/modernize/testdata/src/errorsastype/errorsastype.go
• M go/analysis/passes/modernize/testdata/src/errorsastype/errorsastype.go.golden

Change size: M

Delta: 3 files changed, 120 insertions(+), 57 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Alan Donovan
• TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: tools

Gerrit-Branch: master

Gerrit-Change-Id: I3d9a378a4ea101f6e7d3e7c4a6e3beba417e3212

Gerrit-Change-Number: 779800

Gerrit-PatchSet: 3

Gerrit-Owner: Madeline Kalil <mka...@google.com>

Gerrit-Reviewer: Alan Donovan <adon...@google.com>

Gerrit-Reviewer: Madeline Kalil <mka...@google.com>

Gerrit-Reviewer: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>