[tools] gopls/internal/cache: share objectpath Encoder across batch

0 views

Skip to first unread message

Alan Donovan (Gerrit)

unread,

Jun 30, 2026, 2:48:04 PM (21 hours ago) Jun 30

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Alex Putman, golang...@luci-project-accounts.iam.gserviceaccount.com, Hongxiang Jiang, Robert Findley, golang-co...@googlegroups.com

Alan Donovan submitted the change

Change information

Commit message:

gopls/internal/cache: share objectpath Encoder across batch

This CL causes an entire batch of type checking to share one
objectpath.Encoder. Since type checking is concurrent, this
requires serializing access to the encoder state. This could be
done by an external mutex, but it is cleaner to make Encoder
do the locking itself, since it can avoid it for most queries.

This reduces the CPU usage of objectpath.Encoder in a clean
'gopls check cmd/kubelet' from 22.0s to 10.4s.
(It was previously about 16% of total CPU; now only 9%)

Similar amortizations are applied to various batched
index construction operations such as method-sets and xrefs.

Thanks to Brian Dillmann at Cockroach Labs for the idea
(github.com/golang/tools/pull/651).

Change-Id: Ie5284e01c7ddbd28baa52281908a5deca3908003

Reviewed-on: https://go-review.googlesource.com/c/tools/+/794560

Reviewed-by: Alex Putman <apu...@golang.org>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files: