[go] go/types, types2: simplify locking in Named.resolveUnderlying

[Gopher Robot (Gerrit)]

Gopher Robot submitted the change

Change information

Commit message:

go/types, types2: simplify locking in Named.resolveUnderlying

Avoid calling Named.resolveUnderlying in the first place (there
is only one caller) if Named.underlying exists already.

In Named.resolveUnderlying remove initial atomic check because
of the check in Named.Underlying. Also, remove a 2nd atomic
check after acquiring the lock as it likely won't help much.

Change-Id: Ife87218fa2549d0903a10218f4dd7a70f85d6c7c

Reviewed-on: https://go-review.googlesource.com/c/go/+/713521

Auto-Submit: Robert Griesemer <g...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Robert Griesemer <g...@google.com>

Reviewed-by: Mark Freeman <markf...@google.com>

Files:

• M src/cmd/compile/internal/types2/named.go
• M src/go/types/named.go

Change size: S

Delta: 2 files changed, 16 insertions(+), 24 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Mark Freeman, +1 by Robert Griesemer
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ife87218fa2549d0903a10218f4dd7a70f85d6c7c

Gerrit-Change-Number: 713521

Gerrit-PatchSet: 2

Gerrit-Owner: Robert Griesemer <g...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Gopher Robot <go...@golang.org>

Gerrit-Reviewer: Mark Freeman <markf...@google.com>

Gerrit-Reviewer: Robert Griesemer <g...@google.com>