[tools] internal/refactor/inline: analyze result type params

0 views

Skip to first unread message

Mateusz Poliwczak (Gerrit)

unread,

Apr 14, 2026, 2:49:22 PM (20 hours ago) Apr 14

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Mark Freeman, golang...@luci-project-accounts.iam.gserviceaccount.com, Jonathan Amsterdam, Alan Donovan, golang-co...@googlegroups.com

Mateusz Poliwczak submitted the change

Change information

Commit message:

internal/refactor/inline: analyze param and result type params

Previously, type parameter references were only analyzed
in the function body. This change analyzes the function params
and result types to find type parameter references.

Fixes golang/go#78435

Change-Id: I393f8c2d5838061b658fcfbff66b1c186a6a6964

Reviewed-on: https://go-review.googlesource.com/c/tools/+/760720

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Jonathan Amsterdam <j...@google.com>

Reviewed-by: Mark Freeman <markf...@google.com>

Auto-Submit: Mateusz Poliwczak <mpoliw...@gmail.com>

Files:

M internal/refactor/inline/callee.go
M internal/refactor/inline/testdata/generic.txtar

Change size: M

Delta: 2 files changed, 99 insertions(+), 4 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Mark Freeman, +2 by Jonathan Amsterdam
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages