[build] internal/relui: fix BaseLink to keep RawPath in sync with Path
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Feb 6, 2026, 1:37:48 PM (2 days ago) Feb 6
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Pratt, Go LUCI, Dmitri Shuralyov, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
internal/relui: fix BaseLink to keep RawPath in sync with Path
The custom functionality to prepend an optional base URL to a target URL
implemented in BaseLink involves modifying the Path field. To avoid
disrupting what the EscapedPath method returns, it's necessary to make
equivalent modifications to the RawPath field when it's present. Do so.
As of CL 732262 it became possible to successfully restart tasks with
characters like "/" in their name, but it turned out to work only when
the -base-url flag was empty. This change makes the non-empty base URL
case also work.
Fixes golang/go#76860 (again).
Change-Id: Ic14549609850b252f5aa9754e6d45149403a15c5
Reviewed-on: https://go-review.googlesource.com/c/build/+/742360
Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Michael Pratt <mpr...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M internal/relui/web.go
- M internal/relui/web_test.go
Change size: S
Delta: 2 files changed, 25 insertions(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Michael Pratt, +1 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages