[crypto] ssh: swap cbcMinPaddingSize to cbcMinPacketSize to get encLength

0 views
Skip to first unread message

Nicola Murino (Gerrit)

unread,
11:28 AM (9 hours ago) 11:28 AM
to Rob Picard, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Carlos Amedee, Roland Shoemaker, Go LUCI, Filippo Valsorda, Gopher Robot, golang-co...@googlegroups.com

Nicola Murino submitted the change

Change information

Commit message:
ssh: swap cbcMinPaddingSize to cbcMinPacketSize to get encLength

The existing code uses cbcMinPaddingSize incorrectly. That value is
also used in the first parameter of the max call, meaning it will
never be used.

Fixes golang/go#78062
Change-Id: I4243ab668168313919df33d78c6965e9eff0e934
Reviewed-by: Roland Shoemaker <rol...@golang.org>
Reviewed-by: Carlos Amedee <car...@golang.org>
Reviewed-by: Nicola Murino <nicola...@gmail.com>
Files:
  • M ssh/cipher.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Carlos Amedee, +1 by Roland Shoemaker, +2 by Nicola Murino
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crypto
Gerrit-Branch: master
Gerrit-Change-Id: I4243ab668168313919df33d78c6965e9eff0e934
Gerrit-Change-Number: 754780
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Picard <rob.p...@goteleport.com>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Nicola Murino <nicola...@gmail.com>
Gerrit-Reviewer: Roland Shoemaker <rol...@golang.org>
Gerrit-CC: Filippo Valsorda <fil...@golang.org>
Gerrit-CC: Gopher Robot <go...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages