[tools] gopls/internal/golang: InlayHint: fix bug in 'var' specs

0 views
Skip to first unread message

Alan Donovan (Gerrit)

unread,
4:31 PM (1 hour ago) 4:31 PM
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Madeline Kalil, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

Alan Donovan submitted the change

Change information

Commit message:
gopls/internal/golang: InlayHint: fix bug in 'var' specs

The logic to traverse ValueSpecs had been broken for a long
time and the tests enshrined the broken behavior. This CL
fixes it.

Fixes golang/go#79531
Change-Id: I0d472a6ca3d03530331ecf5e40c0d62f1d13ee47
Reviewed-by: Madeline Kalil <mka...@google.com>
Files:
  • M gopls/internal/golang/inlay_hint.go
  • M gopls/internal/test/marker/testdata/inlayhints/inlayhints.txt
  • M gopls/internal/test/marker/testdata/inlayhints/issue67142.txt
Change size: S
Delta: 3 files changed, 18 insertions(+), 31 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I0d472a6ca3d03530331ecf5e40c0d62f1d13ee47
Gerrit-Change-Number: 780560
Gerrit-PatchSet: 3
Gerrit-Owner: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Madeline Kalil <mka...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages