[tools] gopls/internal/golang: InlayHint: fix bug in 'var' specs
0 views
Skip to first unread message
Alan Donovan (Gerrit)
4:31 PM (1 hour ago) 4:31 PM
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Madeline Kalil, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Alan Donovan submitted the change![]( "Open in Gerrit")
Change information
Commit message:
gopls/internal/golang: InlayHint: fix bug in 'var' specs
The logic to traverse ValueSpecs had been broken for a long
time and the tests enshrined the broken behavior. This CL
fixes it.
Fixes golang/go#79531
Change-Id: I0d472a6ca3d03530331ecf5e40c0d62f1d13ee47
Reviewed-on: https://go-review.googlesource.com/c/tools/+/780560
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Madeline Kalil <mka...@google.com>
Files:
- M gopls/internal/golang/inlay_hint.go
- M gopls/internal/test/marker/testdata/inlayhints/inlayhints.txt
- M gopls/internal/test/marker/testdata/inlayhints/issue67142.txt
Change size: S
Delta: 3 files changed, 18 insertions(+), 31 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Madeline Kalil
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages