[tools] gopls/internal/test/integragtion: remove obsolete Settings

[Peter Weinberger (Gerrit)]

Peter Weinberger submitted the change

Change information

Commit message:

gopls/internal/test/integragtion: remove obsolete Settings

The setting "importsSource": settings.ImportSourceGopls
is the default, so there is no point to setting in in tests, and
maintainers might well wonder why it was set in some tests and not in
others.

This CL (thank you jetski) removes the setting from tests.

Change-Id: I78868c19b66a0ffdb27789b17ae4d9f5b7548621

Reviewed-on: https://go-review.googlesource.com/c/tools/+/761800

Reviewed-by: Madeline Kalil <mka...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

• M gopls/internal/test/integration/completion/completion_test.go
• M gopls/internal/test/integration/misc/imports_test.go

Change size: S

Delta: 2 files changed, 16 insertions(+), 32 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Madeline Kalil
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: tools

Gerrit-Branch: master

Gerrit-Change-Id: I78868c19b66a0ffdb27789b17ae4d9f5b7548621

Gerrit-Change-Number: 761800

Gerrit-PatchSet: 2

Gerrit-Owner: Peter Weinberger <p...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Madeline Kalil <mka...@google.com>

Gerrit-Reviewer: Peter Weinberger <p...@google.com>