[go] cmd/asm/internal/asm/testdata: add SB tests

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Feb 24, 2026, 4:29:29 PM (11 hours ago) Feb 24
to Roland Shoemaker, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Cherry Mui, Russ Cox, David Chase, golang-co...@googlegroups.com

Gopher Robot submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/cmd/asm/internal/asm/testdata/arm64.s
Insertions: 1, Deletions: 1.

@@ -287,7 +287,7 @@
HINT $0 // 1f2003d5
DMB $1
SVC
- SB // ff3003d5
+ SB // ff3003d5

// encryption
SHA256H V9.S4, V3, V2 // 6240095e
```
```
The name of the file: src/cmd/asm/internal/asm/testdata/arm64error.s
Insertions: 1, Deletions: 1.

@@ -428,5 +428,5 @@
AUTIBSP C // ERROR "illegal combination"
AUTIA1716 $45 // ERROR "illegal combination"
AUTIB1716 R0 // ERROR "illegal combination"
- SB $1 // ERROR "illegal combination"
+ SB $1 // ERROR "illegal combination"
RET
```

Change information

Commit message:
cmd/asm/internal/asm/testdata: add SB tests

Add tests for the SB instruction which were omitted in CL 729501.
Change-Id: Ia71940b813563a418011914660ee0f1aeaa78444
Reviewed-by: Cherry Mui <cher...@google.com>
Auto-Submit: Roland Shoemaker <rol...@golang.org>
Files:
  • M src/cmd/asm/internal/asm/testdata/arm64.s
  • M src/cmd/asm/internal/asm/testdata/arm64enc.s
  • M src/cmd/asm/internal/asm/testdata/arm64error.s
Change size: XS
Delta: 3 files changed, 3 insertions(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Cherry Mui
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ia71940b813563a418011914660ee0f1aeaa78444
Gerrit-Change-Number: 748580
Gerrit-PatchSet: 3
Gerrit-Owner: Roland Shoemaker <rol...@golang.org>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Roland Shoemaker <rol...@golang.org>
Gerrit-Reviewer: Russ Cox <r...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages