[go] cmd/compile: simplify the implementation of LoweredZeroLoop on loong64

0 views

Skip to first unread message

abner chenc (Gerrit)

unread,

Mar 17, 2026, 8:58:20 PM (19 hours ago) Mar 17

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Carlos Amedee, Go LUCI, Keith Randall, Keith Randall, Meidan Li, sophie zhao, Robert Griesemer, Matthew Dempsky, Gopher Robot, golang-co...@googlegroups.com

abner chenc submitted the change with unreviewed changes

Unreviewed changes

3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/cmd/compile/internal/loong64/ssa.go
Insertions: 1, Deletions: 1.

@@ -598,7 +598,7 @@
 		//    BNE     flagReg, lsxInit
 		// genericLoop:
 		//    for off = 0; off < loopSize; off += 8 {
-		//            zero8(s, ptrReg, -off)
+		//            zero8(s, ptrReg, off)
 		//    }
 		//    ADDV    $loopSize, ptrReg
 		//    BNE     endReg, ptrReg, genericLoop
```

Change information

Commit message:

cmd/compile: simplify the implementation of LoweredZeroLoop on loong64

Removes 6484 instructions from the go binary on loong64.

            before     after    delta
asm         561517     561225   -292
cgo         480929     480493   -436
compile    2887121    2886277   -844
cover       530429     530125   -304
fix         851649     851093   -556
link        728361     727813   -548
preprofile  240713     240545   -168
vet         824869     824297   -572
go         1638645    1636053   -2592
gofmt       320213     320041   -172

Change-Id: I15da6e94a4166aed03373657fa4785063aa32f35

Reviewed-on: https://go-review.googlesource.com/c/go/+/754000

Reviewed-by: Keith Randall <k...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Carlos Amedee <car...@golang.org>

Reviewed-by: Keith Randall <k...@golang.org>

Reviewed-by: Meidan Li <lime...@loongson.cn>

Files:

M src/cmd/compile/internal/loong64/ssa.go

Change size: M

Delta: 1 file changed, 37 insertions(+), 47 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Meidan Li, +2 by Keith Randall, +1 by Carlos Amedee, +1 by Keith Randall
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages