[go] cmd/link: make TestTypePlacement work on AIX

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Feb 6, 2026, 6:30:49 PM (2 days ago) Feb 6
to Ian Lance Taylor, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Pratt, Cherry Mui, Go LUCI, Than McIntosh, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
cmd/link: make TestTypePlacement work on AIX

The existing code was just wrong. On AIX the go.type section is
folded into the .text section (when internally linking),
or the .data section (when externally linking).
It follows that the data section adjustment is useless when
internally linking, which is currently what happens with this test.
Change-Id: Icf8ac07f754fdcf08b9d3dfffde83b3391c9404b
Auto-Submit: Ian Lance Taylor <ia...@golang.org>
Reviewed-by: Cherry Mui <cher...@google.com>
Reviewed-by: Michael Pratt <mpr...@google.com>
Files:
  • M src/cmd/link/link_test.go
Change size: S
Delta: 1 file changed, 35 insertions(+), 10 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael Pratt, +2 by Cherry Mui
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Icf8ac07f754fdcf08b9d3dfffde83b3391c9404b
Gerrit-Change-Number: 740821
Gerrit-PatchSet: 5
Gerrit-Owner: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-CC: Than McIntosh <th...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages