[build] internal/relui: fix URL path segment escaping for task names
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Jan 16, 2026, 5:17:53 PM (2 days ago) Jan 16
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Michael Knyszek, Dmitri Shuralyov, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
internal/relui: fix URL path segment escaping for task names
url.PathEscape can be used to escape a string so it can be safely placed
inside a URL path segment. Do so, which after migrating to http.ServeMux
and its pattern matching makes it possible to successfully restart tasks
with characters like "/" in their name (e.g., such as a task named "Wait
for x/tools stdlib CL submission" where we first ran into this).
Fixes golang/go#76860.
Change-Id: Ie69516e0f3b440baf6cdd60dbc4f5785cd24a822
Reviewed-on: https://go-review.googlesource.com/c/build/+/732262
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>
Reviewed-by: Michael Knyszek <mkny...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M internal/relui/templates/task_list.html
- M internal/relui/web.go
- M internal/relui/web_test.go
Change size: S
Delta: 3 files changed, 36 insertions(+), 2 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Michael Knyszek, +1 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages