[go] runtime: enable crash dump creation on Windows without fault reporting UI
218 views
Skip to first unread message
Patrik Nyblom (Gerrit)
Oct 29, 2021, 1:59:21 PM10/29/21
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go Bot, Alessandro Arzilli, Alex Brainman, Ian Lance Taylor, Austin Clements, Dmitry Vyukov, Martin Möhrmann, golang-co...@googlegroups.com
Patrik Nyblom submitted this change.
11 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Approvals:
Patrik Nyblom: Looks good to me, approved
Alex Brainman: Trusted
Alessandro Arzilli: Run TryBots
Go Bot: TryBots succeeded
runtime: enable crash dump creation on Windows
This change provides ability to create dumps on Windows that can be used by
"dlv core" command. Currently only full dumps can be correctly read by Delve.
Below are the steps to create and use the dumps.
1. Configure Windows OS to collect dumps before running the program.
Instructions on how to do the configuration are here:
https://docs.microsoft.com/en-us/windows/win32/wer/collecting-user-mode-dumps.
In order for Delve to read the dump, set the DumpType to full dump, i.e. DumpType=2.
2. Go program only generates dumps when the environment variable GOTRACEBACK
is set to crash. Run command "set GOTRACEBACK=crash" before running the program.
3. Dump files will be generated in %LOCALAPPDATA%\CrashDumps
4. Use Delve command "dlv core" to open the dump, e.g.: "dlv core a.exe a.exe.3840.dmp".
Fixes #20498
Change-Id: Ib9aa82e7aea9da19594dc49348876997b24e9600
Reviewed-on: https://go-review.googlesource.com/c/go/+/307372
Run-TryBot: Alessandro Arzilli <alessandr...@gmail.com>
TryBot-Result: Go Bot <go...@golang.org>
Reviewed-by: Patrik Nyblom <pn...@google.com>
Trust: Alex Brainman <alex.b...@gmail.com>
---
M src/runtime/panic.go
M src/runtime/os_windows.go
M src/runtime/signal_windows.go
3 files changed, 99 insertions(+), 22 deletions(-)
diff --git a/src/runtime/os_windows.go b/src/runtime/os_windows.go
index 648239f..0e17e75 100644
--- a/src/runtime/os_windows.go
+++ b/src/runtime/os_windows.go
@@ -40,6 +40,7 @@
//go:cgo_import_dynamic runtime._LoadLibraryW LoadLibraryW%1 "kernel32.dll"
//go:cgo_import_dynamic runtime._LoadLibraryA LoadLibraryA%1 "kernel32.dll"
//go:cgo_import_dynamic runtime._PostQueuedCompletionStatus PostQueuedCompletionStatus%4 "kernel32.dll"
+//go:cgo_import_dynamic runtime._RaiseException RaiseException%4 "kernel32.dll"
//go:cgo_import_dynamic runtime._ResumeThread ResumeThread%1 "kernel32.dll"
//go:cgo_import_dynamic runtime._SetConsoleCtrlHandler SetConsoleCtrlHandler%2 "kernel32.dll"
//go:cgo_import_dynamic runtime._SetErrorMode SetErrorMode%1 "kernel32.dll"
@@ -93,6 +94,7 @@
_PostQueuedCompletionStatus,
_QueryPerformanceCounter,
_QueryPerformanceFrequency,
+ _RaiseException,
_ResumeThread,
_SetConsoleCtrlHandler,
_SetErrorMode,
@@ -120,6 +122,7 @@
_AddVectoredContinueHandler,
_LoadLibraryExA,
_LoadLibraryExW,
+ _WerSetFlags,
_ stdFunction
// Use RtlGenRandom to generate cryptographically random data.
@@ -254,6 +257,7 @@
_AddVectoredContinueHandler = windowsFindfunc(k32, []byte("AddVectoredContinueHandler\000"))
_LoadLibraryExA = windowsFindfunc(k32, []byte("LoadLibraryExA\000"))
_LoadLibraryExW = windowsFindfunc(k32, []byte("LoadLibraryExW\000"))
+ _WerSetFlags = windowsFindfunc(k32, []byte("WerSetFlags\000"))
useLoadLibraryEx = (_LoadLibraryExW != nil && _LoadLibraryExA != nil && _AddDllDirectory != nil)
var advapi32dll = []byte("advapi32.dll\000")
diff --git a/src/runtime/panic.go b/src/runtime/panic.go
index c4f3f41..58135cf 100644
--- a/src/runtime/panic.go
+++ b/src/runtime/panic.go
@@ -975,6 +975,11 @@
// panicking is incremented and decremented atomically.
var panicking uint32
+// tracebackprinted is zero before gopanic() prints the traceback. After
+// traceback is printed, it sets to 1 so that the subsequent exception handler
+// won't print the traceback again.
+var tracebackprinted uint32
+
// paniclk is held while printing the panic information and stack trace,
// so that two concurrent panics don't overlap their output.
var paniclk mutex
@@ -1018,6 +1023,9 @@
startpanic_m()
if dopanic_m(gp, pc, sp) {
+ // At this point, traceback has already been printed.
+ // Set tracebackprinted to 1 to avoid printing traceback again
+ tracebackprinted = 1
// crash uses a decent amount of nosplit stack and we're already
// low on stack in throw, so crash on the system stack (unlike
// fatalpanic).
@@ -1059,6 +1067,9 @@
})
if docrash {
+ // At this point, traceback has already been printed.
+ // Set tracebackprinted to 1 to avoid printing traceback again
+ tracebackprinted = 1
// By crashing outside the above systemstack call, debuggers
// will not be confused when generating a backtrace.
// Function crash is marked nosplit to avoid stack growth.
diff --git a/src/runtime/signal_windows.go b/src/runtime/signal_windows.go
index 16c36d0..ca4a9ea 100644
--- a/src/runtime/signal_windows.go
+++ b/src/runtime/signal_windows.go
@@ -22,6 +22,30 @@
stdcall1(_SetErrorMode, uintptr(errormode)|SEM_FAILCRITICALERRORS|SEM_NOGPFAULTERRORBOX|SEM_NOOPENFILEERRORBOX)
}
+// enableWERNoUI re-enables Windows error reporting without fault reporting UI.
+// It returns false on older Windows versions (XP and earlier) where WerSetFlags() is not supported.
+//
+// This is marked nosplit since it is used during crash.
+//
+//go:nosplit
+func enableWERNoUI() bool {
+ if _WerSetFlags == nil {
+ return false
+ }
+
+ // Disable Fault reporting UI
+ const (
+ WER_FAULT_REPORTING_NO_UI = 0x0020
+ )
+ if stdcall1(_WerSetFlags, WER_FAULT_REPORTING_NO_UI) != 0 {
+ return false
+ }
+
+ // re-enable Windows Error Reporting
+ stdcall1(_SetErrorMode, 0)
+ return true
+}
+
// in sys_windows_386.s and sys_windows_amd64.s
func exceptiontramp()
func firstcontinuetramp()
@@ -108,6 +132,7 @@
// Don't go through any more of the Windows handler chain.
// Crash now.
winthrow(info, r, gp)
+ exit(2)
}
// After this point, it is safe to grow the stack.
@@ -196,6 +221,15 @@
}
winthrow(info, r, gp)
+
+ _, _, docrash := gotraceback()
+ if docrash {
+ // trigger crash dump creation
+ if enableWERNoUI() {
+ return _EXCEPTION_CONTINUE_SEARCH
+ }
+ }
+ exit(2)
return 0 // not reached
}
@@ -203,11 +237,6 @@
func winthrow(info *exceptionrecord, r *context, gp *g) {
_g_ := getg()
- if panicking != 0 { // traceback already printed
- exit(2)
- }
- panicking = 1
-
// In case we're handling a g0 stack overflow, blow away the
// g0 stack bounds so we have room to print the traceback. If
// this somehow overflows the stack, the OS will trap it.
@@ -229,18 +258,16 @@
_g_.m.throwing = 1
_g_.m.caughtsig.set(gp)
- level, _, docrash := gotraceback()
+ level, _, _ := gotraceback()
if level > 0 {
- tracebacktrap(r.ip(), r.sp(), r.lr(), gp)
- tracebackothers(gp)
+ // only print traceback when it hasn't been printed
+ if tracebackprinted == 0 {
+ tracebacktrap(r.ip(), r.sp(), r.lr(), gp)
+ tracebackothers(gp)
+ tracebackprinted = 1
+ }
dumpregs(r)
}
-
- if docrash {
- crash()
- }
-
- exit(2)
}
func sigpanic() {
@@ -312,14 +339,17 @@
//go:nosplit
func crash() {
- // TODO: This routine should do whatever is needed
- // to make the Windows program abort/crash as it
- // would if Go was not intercepting signals.
- // On Unix the routine would remove the custom signal
- // handler and then raise a signal (like SIGABRT).
- // Something like that should happen here.
- // It's okay to leave this empty for now: if crash returns
- // the ordinary exit-after-panic happens.
+ // When GOTRACEBACK==crash, raise the same exception
+ // from kernel32.dll, so that Windows gets a chance
+ // to handle the exception by creating a crash dump.
+
+ // Get the Exception code that caused the crash
+ gp := getg()
+ exceptionCode := gp.sig
+
+ // RaiseException() here will not be handled in exceptionhandler()
+ // because it comes from kernel32.dll
+ stdcall4(_RaiseException, uintptr(unsafe.Pointer(&exceptionCode)), 0, 0, 0)
}
// gsignalStack is unused on Windows.
To view, visit change 307372. To unsubscribe, or for help writing mail filters, visit settings.
Reply all
Reply to author
Forward
0 new messages