[go] go/internal/gcimporter: remove typo'd r.Bool()

0 views

Skip to first unread message

Mark Freeman (Gerrit)

unread,

Apr 14, 2026, 12:10:20 PM (23 hours ago) Apr 14

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Robert Griesemer, Alan Donovan, golang-co...@googlegroups.com

Mark Freeman submitted the change

Unreviewed changes

3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

go/internal/gcimporter: remove incorrect r.Bool() read

This was meant to be an exact copy of this snippet from the compiler's
importer:

	nreceivers := 0
	if r.Version().Has(pkgbits.GenericMethods) {
		nreceivers = r.Len()
	}
	nexplicits := r.Len()

An additional r.Bool() read was likely copied from a similar version
check nearby; it's not the appropriate version check in this case. This
copy / paste error was unfortunately copied to the x/tools importer too.

Change-Id: I295f1e50d21ee2901220c549bae2b64302da4866

Reviewed-on: https://go-review.googlesource.com/c/go/+/765445

Reviewed-by: Robert Griesemer <g...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Alan Donovan <adon...@google.com>

Files:

M src/go/internal/gcimporter/ureader.go

Change size: XS

Delta: 1 file changed, 1 insertion(+), 1 deletion(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Robert Griesemer, +2 by Alan Donovan
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages