[tools] refactor/satisfy/find.go: fix panic on type errors

[Peter Weinberger (Gerrit)]

Peter Weinberger submitted the change

Change information

Commit message:

refactor/satisfy/find.go: fix panic on type errors

This CL fixes a panic that occurs when trying to use the Type()
when there is a type error in a dependency during a Rename operation.

There is also a new test, checking that some parts of a Rename still
succeeds.

There are new checks in two places where the code seemed overly
optimistic.

Fixes: golang/go#71657

Change-Id: I63a2128f8a34a8dc7eddc4165e45a406389e89aa

Reviewed-on: https://go-review.googlesource.com/c/tools/+/809220

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Madeline Kalil <mka...@google.com>

Files:

• M gopls/internal/test/integration/misc/rename_test.go
• M refactor/satisfy/find.go

Change size: M

Delta: 2 files changed, 78 insertions(+), 3 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Madeline Kalil
• TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: tools

Gerrit-Branch: master

Gerrit-Change-Id: I63a2128f8a34a8dc7eddc4165e45a406389e89aa

Gerrit-Change-Number: 809220

Gerrit-PatchSet: 5

Gerrit-Owner: Peter Weinberger <p...@google.com>

Gerrit-Reviewer: Madeline Kalil <mka...@google.com>

Gerrit-Reviewer: Peter Weinberger <p...@google.com>

Gerrit-Reviewer: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Gopher Robot <go...@golang.org>