[go] cmd/compile: rewrite proved multiplies by 0 or 1 into CondSelect

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Oct 28, 2025, 10:51:55 AM (8 days ago) Oct 28
to Jorropo, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Knyszek, Go LUCI, Keith Randall, Keith Randall, Filippo Valsorda, Martin Möhrmann, golang-co...@googlegroups.com

Gopher Robot submitted the change

Unreviewed changes

5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
cmd/compile: rewrite proved multiplies by 0 or 1 into CondSelect

Updates #76056
Change-Id: I64fe631ab381c74f902f877392530d7cc91860ab
Reviewed-by: Michael Knyszek <mkny...@google.com>
Auto-Submit: Jorropo <jorro...@gmail.com>
Reviewed-by: Keith Randall <k...@google.com>
Reviewed-by: Keith Randall <k...@golang.org>
Files:
  • M src/cmd/compile/internal/ssa/branchelim.go
  • M src/cmd/compile/internal/ssa/prove.go
  • M test/prove.go
Change size: M
Delta: 3 files changed, 65 insertions(+), 2 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Keith Randall, +2 by Keith Randall, +1 by Michael Knyszek
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I64fe631ab381c74f902f877392530d7cc91860ab
Gerrit-Change-Number: 715044
Gerrit-PatchSet: 7
Gerrit-Owner: Jorropo <jorro...@gmail.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Keith Randall <k...@google.com>
Gerrit-Reviewer: Martin Möhrmann <moeh...@google.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-CC: Filippo Valsorda <fil...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages