[go] cmd/go: move mod_insecure_issue63845 and mod_proxy_https to verylongtest

0 views

Skip to first unread message

Michael Matloob (Gerrit)

unread,

2:54 PM (6 hours ago) 2:54 PM

to Michael Matloob, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, Dmitri Shuralyov, golang-co...@googlegroups.com

Michael Matloob submitted the change

Unreviewed changes

7 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

cmd/go: move mod_insecure_issue63845 and mod_proxy_https to verylongtest

Ideally we could convert them to not use net but for now let's isolate
them. mod_proxy_https is probably easier to convert, but we'd have to
start serving an HTTPS proxy for it.

The net condition is simple than the one in the standard suite because
it doens't enable network access, it just checks if it's available.

The git condition is a copy of the condition in the standard suite.

We also add GOROOT to the tests' environment so the mod_proxy_https test
case can find the go.env file.

For #80243

Change-Id: I3b36b927be34f15cf4e933805c73cdae6a6a6964

Reviewed-on: https://go-review.googlesource.com/c/go/+/796000

Reviewed-by: Michael Matloob <mat...@google.com>

Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>

Reviewed-by: Dmitri Shuralyov <dmit...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

M src/cmd/go/internal/verylongtest/script_test.go
D src/cmd/go/internal/verylongtest/testdata/script/README
R src/cmd/go/internal/verylongtest/testdata/script/mod_insecure_issue63845.txt
R src/cmd/go/internal/verylongtest/testdata/script/mod_proxy_https.txt

Change size: L

Delta: 4 files changed, 23 insertions(+), 292 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Dmitri Shuralyov, +1 by Michael Matloob, +1 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages