[go] go/ast: add ParseDirective for parsing directive comments

1 view

Skip to first unread message

Gopher Robot (Gerrit)

unread,

Oct 21, 2025, 5:49:15 PM (2 days ago) Oct 21

to Austin Clements, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Alan Donovan, Mateusz Poliwczak, golang-co...@googlegroups.com

Gopher Robot submitted the change with unreviewed changes

Unreviewed changes

7 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/go/ast/directive.go
Insertions: 1, Deletions: 1.

@@ -112,7 +112,7 @@
 // double quoted Go string, or a back quoted raw Go string. Each token must be
 // separated by one or more Unicode spaces.
 //
-// If the arguments do not obey this syntax, it returns an error.
+// If the arguments do not conform to this syntax, it returns an error.
 func (d *Directive) ParseArgs() ([]DirectiveArg, error) {
 	args := directiveScanner{d.Args, d.ArgsPos}
 
```

Change information

Commit message:

go/ast: add ParseDirective for parsing directive comments

This adds an ast.Directive API for parsing directive comments such as
"//go:build" and "//go:embed".

This will help tools standardize the syntax of these directive
comments. Even within the standard Go tools there's little agreement
on the finer details of the syntax of directives today.

Fixes #68021.

Change-Id: I84a988a667682c9ac70632df6e925461ac95e381

Reviewed-on: https://go-review.googlesource.com/c/go/+/704835

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Auto-Submit: Austin Clements <aus...@google.com>

Reviewed-by: Mateusz Poliwczak <mpoliw...@gmail.com>

Reviewed-by: Alan Donovan <adon...@google.com>

Files: