[go] cmd/internal/obj/loong64: fix illegal instruction combination

0 views

Skip to first unread message

abner chenc (Gerrit)

unread,

Apr 14, 2026, 11:34:39 PM (11 hours ago) Apr 14

to Meidan Li, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Mark Freeman, David Chase, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

abner chenc submitted the change

Change information

Commit message:

cmd/internal/obj/loong64: fix illegal instruction combination

The instruction VSLT.B does not have a parameter of type U5CON, but
rather of type S5CON, while the instruction VSLTBU is the opposite.

The instruction AVANDV has same oprand combinations with AVADDB, so
remove it from optab.

Fix other incorrect sharing operations on optab in the buildop
function.

Change-Id: I1238b6b9f7bf18319c1cb7d981803c646df8db0c

Reviewed-on: https://go-review.googlesource.com/c/go/+/765160

Reviewed-by: abner chenc <chen...@loongson.cn>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: David Chase <drc...@google.com>

Reviewed-by: Mark Freeman <markf...@google.com>

Files:

M src/cmd/asm/internal/asm/testdata/loong64enc1.s
M src/cmd/internal/obj/loong64/asm.go

Change size: L

Delta: 2 files changed, 246 insertions(+), 213 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by David Chase, +1 by Mark Freeman, +2 by abner chenc
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages