[go] net: fix TestLookupCNAME
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Jun 30, 2026, 4:43:56 PM (20 hours ago) Jun 30
to Nicholas Husin, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Damien Neil, Nicholas Husin, Russ Cox, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
net: fix TestLookupCNAME
The CNAME record for www.iana.org seems to have been changed, causing
test failures.
Change the test to just use www.golang.org, so we have more control and
awareness of such changes in the future.
Fixes #80212
Change-Id: I7b11bb8f90fe366db019dab1f8d9a1cf6a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/795840
Auto-Submit: Nicholas Husin <hu...@google.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Russ Cox <r...@golang.org>
Reviewed-by: Damien Neil <dn...@google.com>
Reviewed-by: Nicholas Husin <hu...@google.com>
Files:
- M src/net/lookup_test.go
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Nicholas Husin, +2 by Russ Cox, +2 by Damien Neil
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Jun 30, 2026, 5:03:29 PM (19 hours ago) Jun 30
to Nicholas Husin, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Junyang Shao, Nicholas Husin, Dmitri Shuralyov, Dmitri Shuralyov, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[release-branch.go1.25] net: fix TestLookupCNAME
The CNAME record for www.iana.org seems to have been changed, causing
test failures.
Change the test to just use www.golang.org, so we have more control and
awareness of such changes in the future.
For #80212
Fixes #80216
Change-Id: I7b11bb8f90fe366db019dab1f8d9a1cf6a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/795842
Reviewed-by: Nicholas Husin <hu...@google.com>
Auto-Submit: Junyang Shao <shaoj...@google.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Junyang Shao <shaoj...@google.com>
Files:
- M src/net/lookup_test.go
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/release-branch.go1.25
Submit Requirements:
Code-Review: +2 by Dmitri Shuralyov, +1 by Nicholas Husin, +1 by Junyang Shao
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Jun 30, 2026, 5:08:21 PM (19 hours ago) Jun 30
to Nicholas Husin, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Junyang Shao, Nicholas Husin, Dmitri Shuralyov, Dmitri Shuralyov, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[release-branch.go1.26] net: fix TestLookupCNAME
The CNAME record for www.iana.org seems to have been changed, causing
test failures.
Change the test to just use www.golang.org, so we have more control and
awareness of such changes in the future.
For #80212
Fixes #80217
Change-Id: I7b11bb8f90fe366db019dab1f8d9a1cf6a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/795841
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Nicholas Husin <hu...@google.com>
Reviewed-by: Junyang Shao <shaoj...@google.com>
Auto-Submit: Junyang Shao <shaoj...@google.com>
Files:
- M src/net/lookup_test.go
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/release-branch.go1.26
Submit Requirements:
Code-Review: +2 by Dmitri Shuralyov, +1 by Junyang Shao, +1 by Nicholas Husin
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages