[tools] internal/lsp/template: add missed hover cases

0 views

Skip to first unread message

Peter Weinberger (Gerrit)

unread,

Dec 7, 2021, 5:04:32 PM12/7/21

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Hyang-Ah Hana Kim, Gopher Robot, kokoro, golang-co...@googlegroups.com

Peter Weinberger submitted this change.

View Change

Approvals:
  Hyang-Ah Hana Kim: Looks good to me, approved
  Peter Weinberger: Trusted; Run TryBots
  Gopher Robot: TryBots succeeded
  kokoro: gopls CI succeeded

internal/lsp/template: add missed hover cases

Templates were reporting 'oops' when hovering over a string.

Fixes: golang/go#50031

Change-Id: I9e256b1f7d193bf090590c1ec71e85fc8493d7f7
Reviewed-on: https://go-review.googlesource.com/c/tools/+/369956
Run-TryBot: Peter Weinberger <p...@google.com>
gopls-CI: kokoro <noreply...@google.com>
TryBot-Result: Gopher Robot <go...@golang.org>
Trust: Peter Weinberger <p...@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hya...@gmail.com>
---
M internal/lsp/template/implementations.go
1 file changed, 25 insertions(+), 0 deletions(-)

diff --git a/internal/lsp/template/implementations.go b/internal/lsp/template/implementations.go
index 66dcc4b..2db0341 100644
--- a/internal/lsp/template/implementations.go
+++ b/internal/lsp/template/implementations.go
@@ -118,6 +118,12 @@
 		ans.Contents.Value = fmt.Sprintf("template %s\n(add definition)", sym.name)
 	case protocol.Namespace:
 		ans.Contents.Value = fmt.Sprintf("template %s defined", sym.name)
+	case protocol.Number:
+		ans.Contents.Value = "number"
+	case protocol.String:
+		ans.Contents.Value = "string"
+	case protocol.Boolean:
+		ans.Contents.Value = "boolean"
 	default:
 		ans.Contents.Value = fmt.Sprintf("oops, sym=%#v", sym)
 	}

To view, visit change 369956. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward

0 new messages