[pkgsite] internal/tests/api: ignore TestAPI/db/module commit time

1 view

Skip to first unread message

Jonathan Amsterdam (Gerrit)

unread,

May 13, 2026, 3:40:59 PM (3 days ago) May 13

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, kokoro, Ethan Lee, Hyang-Ah Hana Kim, golang-co...@googlegroups.com

Jonathan Amsterdam submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: internal/tests/api/api_test.go
Insertions: 0, Deletions: 1.

@@ -636,7 +636,6 @@
 				if err != nil {
 					t.Fatalf("unmarshaling: %v", err)
 				}
-
 				if diff := cmp.Diff(test.want, got, diffOptions...); diff != "" {
 					t.Errorf("mismatch (-want +got):\n%s", diff)
 				}
```

Change information

Commit message:

internal/tests/api: ignore TestAPI/db/module commit time

Interactions with the DB using local time and JSON truncating times
to the nearest minute caused CommitTime comparisons to fail with the DB.
Ignore commit time.

Change-Id: I5411a04e2fbeeed4760c09d612dbc637c593b861

Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/777440

kokoro-CI: kokoro <noreply...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Ethan Lee <etha...@google.com>

Files:

M internal/tests/api/api_test.go

Change size: XS

Delta: 1 file changed, 1 insertion(+), 0 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Ethan Lee
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
kokoro-CI-Passes: kokoro-CI+1 by kokoro

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages