[go] runtime,syscall: implement and use syscallN on darwin

1 view
Skip to first unread message

Quim Muntal (Gerrit)

unread,
Oct 21, 2025, 4:19:53 PM (2 days ago) Oct 21
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, David Chase, Michael Pratt, Go LUCI, Cherry Mui, golang-co...@googlegroups.com

Quim Muntal submitted the change

Change information

Commit message:
runtime,syscall: implement and use syscalln on darwin

All darwin syscall implementations can be consolidated into a
single syscalln function, as already happens on Windows.

This reduces duplication and allows moving some logic from
runtime to syscall.

Updates #699135
Cq-Include-Trybots: luci.golang.try:gotip-darwin-arm64-longtest,gotip-darwin-amd64-longtest,x_sys-gotip-darwin-arm64-longtest,x_sys-gotip-darwin-amd64-longtest
Change-Id: If5de80442b1d4a1123258401a3ae21695e7c8f6b
Reviewed-by: David Chase <drc...@google.com>
Reviewed-by: Michael Pratt <mpr...@google.com>
Files:
  • M src/internal/trace/trace_test.go
  • M src/runtime/os_darwin.go
  • M src/runtime/sys_darwin.go
  • M src/runtime/sys_darwin_amd64.s
  • M src/runtime/sys_darwin_arm64.s
  • M src/syscall/syscall_darwin.go
  • M src/syscall/syscall_darwin_amd64.go
  • M src/syscall/syscall_darwin_arm64.go
Change size: L
Delta: 8 files changed, 308 insertions(+), 385 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Michael Pratt, +1 by David Chase
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: If5de80442b1d4a1123258401a3ae21695e7c8f6b
Gerrit-Change-Number: 699177
Gerrit-PatchSet: 32
Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages