[tools] gopls/internal/test/misc: Fix two flaky tests

[Peter Weinberger (Gerrit)]

Peter Weinberger submitted the change

Change information

Commit message:

gopls/internal/test/misc: Fix two flaky tests

In gopls the module index is maintained with background
go routines. Tests that depend on the module index will be flaky
if the background work doesn't finish in time. Instead, construct
the module index deterministically.

Fixes: golang/go#77552

Fixes: golang/go#77894

Change-Id: I9f458d02e044d5d708a49faeae41c7554d0e1498

Reviewed-on: https://go-review.googlesource.com/c/tools/+/796440

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Madeline Kalil <mka...@google.com>

Files:

• M gopls/internal/test/integration/misc/imports_test.go

Change size: M

Delta: 1 file changed, 10 insertions(+), 47 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Madeline Kalil
• TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: tools

Gerrit-Branch: master

Gerrit-Change-Id: I9f458d02e044d5d708a49faeae41c7554d0e1498

Gerrit-Change-Number: 796440

Gerrit-PatchSet: 2

Gerrit-Owner: Peter Weinberger <p...@google.com>

Gerrit-Reviewer: Madeline Kalil <mka...@google.com>

Gerrit-Reviewer: Peter Weinberger <p...@google.com>

Gerrit-Reviewer: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>