[vscode-go] extension/src: sync protocol changes from CL 765240

0 views

Skip to first unread message

Hongxiang Jiang (Gerrit)

unread,

Jun 5, 2026, 4:53:42 PM (2 days ago) Jun 5

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Madeline Kalil, Danny Tuppeny, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

Hongxiang Jiang submitted the change

Change information

Commit message:

extension/src: sync protocol changes from CL 765240

gopls v0.22.0 does not strictly follow the protocol. The language client
expects a struct from langauge server but gopls v0.22.0 send a slice of
string. Hence, the client will consider the server incapable of handling
interactive commands.

The interactive refactoring E2E is disabled as the vscode-go extension
run test against the last released version of gopls (i.e. gopls
v0.22.0).

As we documented in proposal, we recommend the language client to prompt
questions with invalid / missing answer, the test will throw an error if
the valid question get re-prompt again.

Demo=https://github.com/user-attachments/assets/4f4a0ce8-dd72-4087-8440-5779bb1d3be8
Test=https://github.com/user-attachments/assets/4a9d53ab-6259-49fd-89b6-25eefe39ff1f

gopls CL 784882

For golang/go#76331

Change-Id: Ie2d0032497308fcf14e9fa67081ad541d49ab54e

Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/784640

Reviewed-by: Danny Tuppeny <da...@tuppeny.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Madeline Kalil <mka...@google.com>

Files:

M extension/src/language/form.ts
M extension/test/gopls/interactive.test.ts

Change size: M

Delta: 2 files changed, 106 insertions(+), 27 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Danny Tuppeny, +2 by Madeline Kalil
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages