[website] cmd/golangorg: support absolute paths in testTree
0 views
Skip to first unread message
Gopher Robot (Gerrit)
1:58 PM (9 hours ago) 1:58 PM
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Alan Donovan, Dmitri Shuralyov, Go LUCI, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
cmd/golangorg: support absolute paths in testTree
The use of strings.TrimPrefix on filepath.ToSlash output works on all
OSes when testTree is given a relative path like "../../_content",
but it doesn't work on Windows if testTree is given an absolute path.
The next change will do that (in order to process GOROOT/doc content),
so prepare for it by migrating to filepath.Rel to compute relative path.
For golang/go#78211.
Change-Id: I2117d916e1c4112bfbd667597e32622039040dd0
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Alan Donovan <adon...@google.com>
Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M cmd/golangorg/server_test.go
Change size: S
Delta: 1 file changed, 12 insertions(+), 7 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Alan Donovan, +1 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages