Damien Neil (Gerrit)

unread,

Apr 20, 2026, 12:27:39 PM (10 days ago) Apr 20

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Nicholas Husin, Nicholas Husin, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

Damien Neil submitted the change

Change information

Commit message:

os: avoid panic when RemoveAll fails to remove a symlink

Fix a case where RemoveAll directly returned the error returned
from openDirAt. When the target of openDirAt is a symlink,
it returns an internal-use-only errSymlink error. This error
panics when printed, to catch misuse of openDirAt.

Fix RemoveAll to detect and handle the errSymlink return.

Fixes #78490

Change-Id: Ibd857280bfca1feb50c163a6e4b192716a6a6964

Reviewed-on: https://go-review.googlesource.com/c/go/+/763520

Reviewed-by: Nicholas Husin <hu...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Nicholas Husin <n...@golang.org>

Files:

M src/os/removeall_at.go
M src/os/removeall_test.go
M src/os/removeall_unix.go
M src/os/removeall_windows.go

Change size: M

Delta: 4 files changed, 40 insertions(+), 22 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Nicholas Husin, +1 by Nicholas Husin
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Michael Pratt (Gerrit)

unread,

Apr 29, 2026, 4:44:16 PM (20 hours ago) Apr 29

to Michael Pratt, Damien Neil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Robert Griesemer, Robert Griesemer, Ian Lance Taylor, Russ Cox, Gopher Robot, golang-co...@googlegroups.com

Michael Pratt submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

[release-branch.go1.26] os: avoid panic when RemoveAll fails to remove a symlink



Fix a case where RemoveAll directly returned the error returned
from openDirAt. When the target of openDirAt is a symlink,
it returns an internal-use-only errSymlink error. This error
panics when printed, to catch misuse of openDirAt.

Fix RemoveAll to detect and handle the errSymlink return.

For #78490
Fixes #78867



Change-Id: Ibd857280bfca1feb50c163a6e4b192716a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/763520
Reviewed-by: Nicholas Husin <hu...@google.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Nicholas Husin <n...@golang.org>

(cherry picked from commit 5ddbf4b0e3be9e22b719b8a6a5aeb20029839972)
Reviewed-on: https://go-review.googlesource.com/c/go/+/769021
Reviewed-by: Robert Griesemer <g...@google.com>

Files:

M src/os/removeall_at.go
M src/os/removeall_test.go
M src/os/removeall_unix.go
M src/os/removeall_windows.go

Change size: M

Delta: 4 files changed, 40 insertions(+), 22 deletions(-)

Branch: refs/heads/release-branch.go1.26

Submit Requirements:

Code-Review: +2 by Robert Griesemer

TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Michael Pratt (Gerrit)

unread,

Apr 29, 2026, 4:44:22 PM (20 hours ago) Apr 29

to Michael Pratt, Damien Neil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Robert Griesemer, Brad Fitzpatrick, Robert Griesemer, Ian Lance Taylor, Gopher Robot, golang-co...@googlegroups.com

Michael Pratt submitted the change

Change information

Commit message:

[release-branch.go1.25] os: avoid panic when RemoveAll fails to remove a symlink



Fix a case where RemoveAll directly returned the error returned
from openDirAt. When the target of openDirAt is a symlink,
it returns an internal-use-only errSymlink error. This error
panics when printed, to catch misuse of openDirAt.

Fix RemoveAll to detect and handle the errSymlink return.

For #78490

Fixes #78866



Change-Id: Ibd857280bfca1feb50c163a6e4b192716a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/763520
Reviewed-by: Nicholas Husin <hu...@google.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Nicholas Husin <n...@golang.org>
(cherry picked from commit 5ddbf4b0e3be9e22b719b8a6a5aeb20029839972)

Reviewed-on: https://go-review.googlesource.com/c/go/+/769020
Reviewed-by: Robert Griesemer <g...@google.com>

Files:

M src/os/removeall_at.go
M src/os/removeall_test.go
M src/os/removeall_unix.go
M src/os/removeall_windows.go

Change size: M

Delta: 4 files changed, 40 insertions(+), 22 deletions(-)

Branch: refs/heads/release-branch.go1.25

Submit Requirements:

Code-Review: +2 by Robert Griesemer
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[go] os: avoid panic when RemoveAll fails to remove a symlink

Damien Neil (Gerrit)

Damien Neil submitted the change

Change information

Michael Pratt (Gerrit)

Michael Pratt submitted the change

Unreviewed changes

Change information

Michael Pratt (Gerrit)

Michael Pratt submitted the change

Change information