[go] net/netip: optimize Prefix.String

[Gopher Robot (Gerrit)]

Gopher Robot submitted the change

Change information

Commit message:

net/netip: optimize Prefix.String

goos: linux
goarch: amd64
pkg: net/netip
cpu: Intel(R) Core(TM) Ultra 9 285K
                │ /tmp/BenchmarkPrefixString_before.txt │ /tmp/BenchmarkPrefixString_after.txt │
                │                sec/op                 │    sec/op     vs base                │
PrefixString-24                             33.70n ± 4%   16.28n ± 21%  -51.69% (p=0.000 n=10)

                │ /tmp/BenchmarkPrefixString_before.txt │ /tmp/BenchmarkPrefixString_after.txt │
                │                 B/op                  │     B/op      vs base                │
PrefixString-24                              32.00 ± 0%     16.00 ± 0%  -50.00% (p=0.000 n=10)

                │ /tmp/BenchmarkPrefixString_before.txt │ /tmp/BenchmarkPrefixString_after.txt │
                │               allocs/op               │  allocs/op    vs base                │
PrefixString-24                              2.000 ± 0%     1.000 ± 0%  -50.00% (p=0.000 n=10)

Change-Id: Idc652368c227314ccc74309cded28f40b8d92d90

Reviewed-on: https://go-review.googlesource.com/c/go/+/744320

Auto-Submit: Damien Neil <dn...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Junyang Shao <shaoj...@google.com>

Reviewed-by: Damien Neil <dn...@google.com>

Files:

• M src/net/netip/netip.go
• M src/net/netip/netip_test.go

Change size: S

Delta: 2 files changed, 27 insertions(+), 1 deletion(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +1 by Junyang Shao, +2 by Damien Neil
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Idc652368c227314ccc74309cded28f40b8d92d90

Gerrit-Change-Number: 744320

Gerrit-PatchSet: 3

Gerrit-Owner: Ian Chen <databa...@gmail.com>

Gerrit-Reviewer: Damien Neil <dn...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Gopher Robot <go...@golang.org>

Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>

Gerrit-Reviewer: Junyang Shao <shaoj...@google.com>

Gerrit-CC: Sean Liao <se...@liao.dev>