[go] cmd/compile/interna/noder: correct generic method pointer recivers

[Mark Freeman (Gerrit)]

Mark Freeman submitted the change

Unreviewed changes

3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

cmd/compile/interna/noder: correct generic method pointer receivers

Damien reported a bug whereby we were shaping qualified identifiers
for generic methods with pointer receivers as T.m[...]. The type for
the pointer receiver is encoded as (*T), and when the method name is
appended, it looks for (*T).m[...], finding nothing.

This updates qualified identifiers for generic methods to recognize
pointer receivers as a separate format.

Change-Id: Iecee9bdd45e3d99400ae61f96dc28fa892511bb7

Reviewed-on: https://go-review.googlesource.com/c/go/+/765600

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Robert Griesemer <g...@google.com>

Files:

• M src/cmd/compile/internal/noder/writer.go
• A test/genmeth2.go

Change size: S

Delta: 2 files changed, 30 insertions(+), 2 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Robert Griesemer
• TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Iecee9bdd45e3d99400ae61f96dc28fa892511bb7

Gerrit-Change-Number: 765600

Gerrit-PatchSet: 5

Gerrit-Owner: Mark Freeman <markf...@google.com>

Gerrit-Reviewer: Mark Freeman <markf...@google.com>

Gerrit-Reviewer: Robert Griesemer <g...@google.com>

Gerrit-Reviewer: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>