[go] runtime/cgo: deduplicate x_cgo_init and crosscall1

[Quim Muntal (Gerrit)]

Quim Muntal submitted the change

Unreviewed changes

18 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

runtime/cgo: deduplicate x_cgo_init and crosscall1

Most platforms share the same implementation for x_cgo_init and
crosscall1. Solaris diverges too much and is left for a future CL.

Cq-Include-Trybots: luci.golang.try:gotip-freebsd-amd64,gotip-darwin-amd64_14,gotip-darwin-arm64_15,gotip-netbsd-arm64,gotip-openbsd-ppc64,gotip-solaris-amd64,gotip-linux-ppc64_power10

Change-Id: Ib2eeb6456caa5c055e1ac1907c2fdf63db58dafc

Reviewed-on: https://go-review.googlesource.com/c/go/+/708035

Reviewed-by: Cherry Mui <cher...@google.com>

Reviewed-by: Michael Pratt <mpr...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Junyang Shao <shaoj...@google.com>

Files:

• D src/runtime/cgo/gcc_darwin_amd64.c
• D src/runtime/cgo/gcc_dragonfly_amd64.c
• M src/runtime/cgo/gcc_freebsd.c
• D src/runtime/cgo/gcc_freebsd_amd64.c
• R src/runtime/cgo/gcc_ios_arm64.c
• M src/runtime/cgo/gcc_libinit.c
• D src/runtime/cgo/gcc_linux.c
• D src/runtime/cgo/gcc_linux_amd64.c
• D src/runtime/cgo/gcc_linux_arm64.c
• D src/runtime/cgo/gcc_linux_s390x.c
• M src/runtime/cgo/gcc_netbsd.c
• D src/runtime/cgo/gcc_openbsd.c
• D src/runtime/cgo/gcc_ppc64x.c
• A src/runtime/cgo/gcc_unix.c
• M src/runtime/cgo/libcgo_unix.h

Change size: L

Delta: 15 files changed, 168 insertions(+), 496 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Cherry Mui, +2 by Michael Pratt, +1 by Junyang Shao
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ib2eeb6456caa5c055e1ac1907c2fdf63db58dafc

Gerrit-Change-Number: 708035

Gerrit-PatchSet: 20

Gerrit-Owner: Quim Muntal <quimm...@gmail.com>

Gerrit-Reviewer: Cherry Mui <cher...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>

Gerrit-Reviewer: Junyang Shao <shaoj...@google.com>

Gerrit-Reviewer: Michael Pratt <mpr...@google.com>

Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>

Gerrit-CC: Ingo Oeser <night...@googlemail.com>